<html>
<head><meta charset="utf-8"><title>Integration Test &quot;Marwes/combine&quot; · clippy · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/index.html">clippy</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Integration.20Test.20.22Marwes.2Fcombine.22.html">Integration Test &quot;Marwes/combine&quot;</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="218564311"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Integration%20Test%20%22Marwes/combine%22/near/218564311" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Integration.20Test.20.22Marwes.2Fcombine.22.html#218564311">(Dec 02 2020 at 14:36)</a>:</h4>
<p>Should we disable this integration test until <a href="https://github.com/rust-lang/rust/issues/79560">#79560</a> is fixed? This currently blocks our queue, where we already have 5 PRs <a href="https://github.com/rust-lang/rust-clippy/pulls?q=is%3Apr+is%3Aopen+label%3AS-waiting-on-rustup">waiting to get merged</a>.</p>



<a name="218564596"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Integration%20Test%20%22Marwes/combine%22/near/218564596" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Integration.20Test.20.22Marwes.2Fcombine.22.html#218564596">(Dec 02 2020 at 14:38)</a>:</h4>
<p>I hoped for a quick fix of the linked issue, but nothing was added to the discussion there in the past 2 days.</p>



<a name="218566032"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Integration%20Test%20%22Marwes/combine%22/near/218566032" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eduardo Broto <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Integration.20Test.20.22Marwes.2Fcombine.22.html#218566032">(Dec 02 2020 at 14:48)</a>:</h4>
<p>Given that it's a rustc bug, I think it's OK for the time being</p>



<a name="218569674"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Integration%20Test%20%22Marwes/combine%22/near/218569674" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Integration.20Test.20.22Marwes.2Fcombine.22.html#218569674">(Dec 02 2020 at 15:11)</a>:</h4>
<p>I think rustc should consider reverting the PR introducing the bug, it's blocking quite a lot of things</p>



<a name="218569796"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Integration%20Test%20%22Marwes/combine%22/near/218569796" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Integration.20Test.20.22Marwes.2Fcombine.22.html#218569796">(Dec 02 2020 at 15:12)</a>:</h4>
<p><span class="user-mention" data-user-id="116266">@Santiago Pastorino</span> the PR adding it was for a nightly feature, right? Not a bug fix?</p>



<a name="218570170"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Integration%20Test%20%22Marwes/combine%22/near/218570170" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Integration.20Test.20.22Marwes.2Fcombine.22.html#218570170">(Dec 02 2020 at 15:14)</a>:</h4>
<p>it's not a feature, but it fixes something that wasn't working and should've worked</p>



<a name="218570218"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Integration%20Test%20%22Marwes/combine%22/near/218570218" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Integration.20Test.20.22Marwes.2Fcombine.22.html#218570218">(Dec 02 2020 at 15:15)</a>:</h4>
<p>about the <code>P-critical</code> issue we're working on it</p>



<a name="218570417"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Integration%20Test%20%22Marwes/combine%22/near/218570417" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Integration.20Test.20.22Marwes.2Fcombine.22.html#218570417">(Dec 02 2020 at 15:16)</a>:</h4>
<p>about reverting, is a possibility, I'd leave that decision up to <span class="user-mention" data-user-id="116009">@nikomatsakis</span></p>



<a name="218570634"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Integration%20Test%20%22Marwes/combine%22/near/218570634" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Integration.20Test.20.22Marwes.2Fcombine.22.html#218570634">(Dec 02 2020 at 15:18)</a>:</h4>
<p>the discussion about the issue is happining here <a href="#narrow/stream/241847-t-compiler.2Fwg-incr-comp/topic/.2379560.20.20Internal.20Compiler.20Error.20while.20compiling.20diesel">https://rust-lang.zulipchat.com/#narrow/stream/241847-t-compiler.2Fwg-incr-comp/topic/.2379560.20.20Internal.20Compiler.20Error.20while.20compiling.20diesel</a></p>



<a name="218570695"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Integration%20Test%20%22Marwes/combine%22/near/218570695" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Integration.20Test.20.22Marwes.2Fcombine.22.html#218570695">(Dec 02 2020 at 15:18)</a>:</h4>
<p>we know what's going on, I don't know yet how to fix it, there's some people trying to help</p>



<a name="218571088"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Integration%20Test%20%22Marwes/combine%22/near/218571088" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Integration.20Test.20.22Marwes.2Fcombine.22.html#218571088">(Dec 02 2020 at 15:21)</a>:</h4>
<p>(I think you posted the wrong link)</p>



<a name="218571292"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Integration%20Test%20%22Marwes/combine%22/near/218571292" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Integration.20Test.20.22Marwes.2Fcombine.22.html#218571292">(Dec 02 2020 at 15:22)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/79637">https://github.com/rust-lang/rust/pull/79637</a></p>



<a name="218571354"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Integration%20Test%20%22Marwes/combine%22/near/218571354" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Integration.20Test.20.22Marwes.2Fcombine.22.html#218571354">(Dec 02 2020 at 15:22)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> <a href="#narrow/stream/257328-clippy/topic/Integration.20Test.20.22Marwes.2Fcombine.22/near/218571088">said</a>:</p>
<blockquote>
<p>(I think you posted the wrong link)</p>
</blockquote>
<p>fixed the link</p>



<a name="218571378"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Integration%20Test%20%22Marwes/combine%22/near/218571378" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Integration.20Test.20.22Marwes.2Fcombine.22.html#218571378">(Dec 02 2020 at 15:23)</a>:</h4>
<p>still a revert makes sense if it's causing some pain</p>



<a name="218571395"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Integration%20Test%20%22Marwes/combine%22/near/218571395" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Integration.20Test.20.22Marwes.2Fcombine.22.html#218571395">(Dec 02 2020 at 15:23)</a>:</h4>
<p>we can work on a solution and merge later</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>